Move some Device methods to private section #16259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayerofieiev-tt
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal,
ubcheema,
davorchap and
cfjchu
as code owners
cfjchu
approved these changes
Dec 23, 2024
Comment on lines
-135
to
-137
| std::unordered_set<chip_id_t> get_ethernet_connected_device_ids() const { | ||
| return tt::Cluster::instance().get_ethernet_connected_device_ids(this->id_); | ||
| } |
There was a problem hiding this comment.
There are a number of these kind of methods that just reach into tt::Cluster::instance() to do the lookup. We should be able to strip these methods from Device.
There was a problem hiding this comment.
Yes.
There are also 32 allocator related methods in device.
But before acting on this, must align with stakeholders.
tt-aho
reviewed
Dec 23, 2024
tt-aho
approved these changes
Dec 23, 2024
omilyutin-tt
approved these changes
Dec 23, 2024
TT-BrianLiu
approved these changes
Dec 23, 2024
dmakoviichuk-tt
approved these changes
Dec 23, 2024
Not doing this in this PR, keeping the scope down. |
ayerofieiev-tt
requested review from
bbradelTT,
yugaoTT,
asandhupatlaTT,
ntarafdar,
sjameelTT,
jaykru-tt,
yugi957,
jvegaTT,
llongTT and
nardoTT
as code owners
tt-asaigal
approved these changes
Dec 24, 2024
bbradelTT
approved these changes
Dec 24, 2024
ntarafdar
approved these changes
Dec 24, 2024
arikTT
pushed a commit
that referenced
this pull request
Dec 27, 2024
### Ticket None ### Problem description There are plenty of Device methods which are only used by device itself but they are in a public section This PR depends on #16256 ### What's changed This PR does not add any new functionality, nor changes existing. It shuffles things around. * Moved near every method thats only used by Device to the private section (19) * Re-groupped methods logically: methods that proxy to allocator, to cluster * Moved a couple implementations to cpp * Reviewed usage of some methods, left comments where its desirable to review usage with owners * Removed template where it was not used Whats next: * Discuss and align what we can/want to do about the two outlined groups of methods * Review notes with owners, align on next steps ### Checklist - [ ] [Post commit CI](https://github.com/tenstorrent/tt-metal/actions/runs/12475902305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
None
Problem description
There are plenty of Device methods which are only used by device itself but they are in a public section
This PR depends on #16256
What's changed
This PR does not add any new functionality, nor changes existing. It shuffles things around.
Whats next:
Checklist